Dont manage .rspec{,_parallel} anymore #895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheMeier
approved these changes
May 9, 2024
ekohl
requested changes
May 10, 2024
|
Yes. I will update voxpupuli-test to depend on the latest PSH as soon as it's released. Then we can depend on the newest voxpupuli-test in modulesync_config. |
bastelfreak
added a commit
to bastelfreak/voxpupuli-test
that referenced
this pull request
May 23, 2024
latest version manages rspec like we need that. That means by requiering 7.3, we can delete .rspec/.rspec_parallel from modulesync_config. voxpupuli/modulesync_config#895
ekohl
approved these changes
May 23, 2024
requires puppetlabs/puppetlabs_spec_helper#451 since puppetlabs/puppetlabs_spec_helper#446 the rake task configures the output so we don't need .rspec_parallel anymore. Requires also puppetlabs/puppetlabs_spec_helper#452
bastelfreak
added a commit
to bastelfreak/puppet-example
that referenced
this pull request
May 23, 2024
bastelfreak
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
requires puppetlabs/puppetlabs_spec_helper#451 since puppetlabs/puppetlabs_spec_helper#446 the rake task configures the output so we don't need .rspec_parallel anymore.